|
|
Post by logan on Mar 17, 2020 0:25:54 GMT
Loaded my game, was playing Aegon conquest, my Aegon is old now and both him and Visenya are in a "Knight Quest" (trait) for some reason... and his "Full Blood" trait was replaced by "The pillar displays a dog" trait, which was inherited by him and everyone else in his bloodline.
I'm not sure where this Knight Quest comes from, I had no time to check, or if it's a compatibility issue.
I have also Knight of the Sword Tower from you, the one to send Kingsguard on quests, which might be the issue, or maybe it's something else.
I've tried loading older saves but it's broken in all of them at start-up, guess I'll uninstall some submods and restart.
Just posting to let you know of this issue.
|
|
|
|
Post by Azrael on Mar 17, 2020 23:30:18 GMT
Loaded my game, was playing Aegon conquest, my Aegon is old now and both him and Visenya are in a "Knight Quest" (trait) for some reason... and his "Full Blood" trait was replaced by "The pillar displays a dog" trait, which was inherited by him and everyone else in his bloodline. I'm not sure where this Knight Quest comes from, I had no time to check, or if it's a compatibility issue. I have also Knight of the Sword Tower from you, the one to send Kingsguard on quests, which might be the issue, or maybe it's something else. I've tried loading older saves but it's broken in all of them at start-up, guess I'll uninstall some submods and restart. Just posting to let you know of this issue. Did you add a submod mid-game which added traits? Because of how traits are stored in saves, that would explain traits being replaced by others. |
|
|
|
Post by logan on Mar 19, 2020 16:24:02 GMT
Loaded my game, was playing Aegon conquest, my Aegon is old now and both him and Visenya are in a "Knight Quest" (trait) for some reason... and his "Full Blood" trait was replaced by "The pillar displays a dog" trait, which was inherited by him and everyone else in his bloodline. I'm not sure where this Knight Quest comes from, I had no time to check, or if it's a compatibility issue. I have also Knight of the Sword Tower from you, the one to send Kingsguard on quests, which might be the issue, or maybe it's something else. I've tried loading older saves but it's broken in all of them at start-up, guess I'll uninstall some submods and restart. Just posting to let you know of this issue. Did you add a submod mid-game which added traits? Because of how traits are stored in saves, that would explain traits being replaced by others. Sorry for the late answer and bothering you without making a full check. I didn't do it myself, but I've noticed only now that the steam Artifact Search mod I use was automatically updated mid-game, since it adds 3 artifact, traits that is most likely the reason of this issue. |
|
|
|
Post by 4eyedcuckoobird on Apr 8, 2020 15:32:18 GMT
So I've gone in and made some modifications to the dragon hatching and taming chances, I can share specifics if you'd like that feedback but I basically lowered across the board. I've also made a change so only if you're High Valyrian, you do get a culture bonus (I know it kind of goes opposite to making it all genetic traits) but in the future if their blood got diluted, I think by them being High Valyrian it should be higher and it makes it so only they can reach the original bonuses of 400% for hatching and 3000% for taming (if they are also full blood).
I also made changes to the chances to receive a certain blood trait based on the parents. For example, I think if someone has a parent with full blood and another with no blood trait, I changed it to 50% chance they're half blood, 30% they're slightly diluted and 20% full blood. I don't know, seems to make a bit more sense to me that way rather than the child getting full blood also most of the time. I can share them all if you'd like that feedback.
So my question. In my games I see like low born, no parents Ironborn/Reachman/etc getting the full blood traits. In the OP you say you give it to people with unknown parents, is that to introduce "fresh blood" into the character pool? How can I turn this off or at least lower the chances of it happening? Kind of weird when I see some random Northman with full blood. Thanks.
Overall love the mod! Really opens up dragons to the rest of the people and adds another decision into the marrying process. Which brings me to another question, how could I add a positive modifier to marriage calculations if someone has valyrian blood? Restrict it so only High Valyrian (maybe others as well like Volantene/Lyseni?) culture takes this modifier into account? For example, marrying my Northman who is half blood to a full blooded Targaryen. Since I have the character flag valyrian blood and in this case being half blood, I get two of those green plus signs in my favor.
Thanks!
|
|
|
|
Post by Azrael on Apr 9, 2020 23:54:59 GMT
So I've gone in and made some modifications to the dragon hatching and taming chances, I can share specifics if you'd like that feedback but I basically lowered across the board. I've also made a change so only if you're High Valyrian, you do get a culture bonus (I know it kind of goes opposite to making it all genetic traits) but in the future if their blood got diluted, I think by them being High Valyrian it should be higher and it makes it so only they can reach the original bonuses of 400% for hatching and 3000% for taming (if they are also full blood). I also made changes to the chances to receive a certain blood trait based on the parents. For example, I think if someone has a parent with full blood and another with no blood trait, I changed it to 50% chance they're half blood, 30% they're slightly diluted and 20% full blood. I don't know, seems to make a bit more sense to me that way rather than the child getting full blood also most of the time. I can share them all if you'd like that feedback. So my question. In my games I see like low born, no parents Ironborn/Reachman/etc getting the full blood traits. In the OP you say you give it to people with unknown parents, is that to introduce "fresh blood" into the character pool? How can I turn this off or at least lower the chances of it happening? Kind of weird when I see some random Northman with full blood. Thanks. Overall love the mod! Really opens up dragons to the rest of the people and adds another decision into the marrying process. Which brings me to another question, how could I add a positive modifier to marriage calculations if someone has valyrian blood? Restrict it so only High Valyrian (maybe others as well like Volantene/Lyseni?) culture takes this modifier into account? For example, marrying my Northman who is half blood to a full blooded Targaryen. Since I have the character flag valyrian blood and in this case being half blood, I get two of those green plus signs in my favor. Thanks! That's cool if you want to make personal changes to fit what you want for gameplay. That's what submods are for. I don't know if I'll incorporate those changes into the submod, but I am open to suggestions, for this submod or any others. While I probably won't incorporate what you mentioned in the first part of your post, I did want feedback on the blood inheritance chance, so thank you. I never got any so I didn't change it, but after playing a couple games myself when I last played AGOT, I was thinking of reducing the chances and also writing the code to be more robust than it is right now. That change I probably will do at some point. I don't know when though; when I come back to AGOT and/or when I have the time to do so probably.
The part about giving traits straight to characters with unknown parents was for special cases like Jon Snow, who has his real parents hidden and for Aurane Waters, who is originally High Valyrian himself, but doesn't have both parents listed. I did this because the startup event that gives the traits is dependent on characters' parents and not themselves. I think there was some code in there for generated characters, like when you hire a soldier or a character gets created by an event, etc. which I did add a chance for them to have some sort of blood trait. That could be how you got a random Northman with full blood, if he/she doesn't have parents. I'll take a look and see if any of those should be lowered.
For the last part, I think the marriage AI is hard-coded for the most part. I don't think there's a way to mod how attractive traits are in terms of marriage for the AI. The AI generally does marriages based on how much prestige, alliances, etc. they would get. The workaround would probably have to be done through events. I know the main AGOT mod has it where Valyrian and characters with silver hair generally marry those of the same. I haven't looked at how that was done, but that was probably done through events.
|
|
|
|
Post by 4eyedcuckoobird on Apr 10, 2020 18:30:21 GMT
So I've gone in and made some modifications to the dragon hatching and taming chances, I can share specifics if you'd like that feedback but I basically lowered across the board. I've also made a change so only if you're High Valyrian, you do get a culture bonus (I know it kind of goes opposite to making it all genetic traits) but in the future if their blood got diluted, I think by them being High Valyrian it should be higher and it makes it so only they can reach the original bonuses of 400% for hatching and 3000% for taming (if they are also full blood). I also made changes to the chances to receive a certain blood trait based on the parents. For example, I think if someone has a parent with full blood and another with no blood trait, I changed it to 50% chance they're half blood, 30% they're slightly diluted and 20% full blood. I don't know, seems to make a bit more sense to me that way rather than the child getting full blood also most of the time. I can share them all if you'd like that feedback. So my question. In my games I see like low born, no parents Ironborn/Reachman/etc getting the full blood traits. In the OP you say you give it to people with unknown parents, is that to introduce "fresh blood" into the character pool? How can I turn this off or at least lower the chances of it happening? Kind of weird when I see some random Northman with full blood. Thanks. Overall love the mod! Really opens up dragons to the rest of the people and adds another decision into the marrying process. Which brings me to another question, how could I add a positive modifier to marriage calculations if someone has valyrian blood? Restrict it so only High Valyrian (maybe others as well like Volantene/Lyseni?) culture takes this modifier into account? For example, marrying my Northman who is half blood to a full blooded Targaryen. Since I have the character flag valyrian blood and in this case being half blood, I get two of those green plus signs in my favor. Thanks! That's cool if you want to make personal changes to fit what you want for gameplay. That's what submods are for. I don't know if I'll incorporate those changes into the submod, but I am open to suggestions, for this submod or any others. While I probably won't incorporate what you mentioned in the first part of your post, I did want feedback on the blood inheritance chance, so thank you. I never got any so I didn't change it, but after playing a couple games myself when I last played AGOT, I was thinking of reducing the chances and also writing the code to be more robust than it is right now. That change I probably will do at some point. I don't know when though; when I come back to AGOT and/or when I have the time to do so probably.
The part about giving traits straight to characters with unknown parents was for special cases like Jon Snow, who has his real parents hidden and for Aurane Waters, who is originally High Valyrian himself, but doesn't have both parents listed. I did this because the startup event that gives the traits is dependent on characters' parents and not themselves. I think there was some code in there for generated characters, like when you hire a soldier or a character gets created by an event, etc. which I did add a chance for them to have some sort of blood trait. That could be how you got a random Northman with full blood, if he/she doesn't have parents. I'll take a look and see if any of those should be lowered.
For the last part, I think the marriage AI is hard-coded for the most part. I don't think there's a way to mod how attractive traits are in terms of marriage for the AI. The AI generally does marriages based on how much prestige, alliances, etc. they would get. The workaround would probably have to be done through events. I know the main AGOT mod has it where Valyrian and characters with silver hair generally marry those of the same. I haven't looked at how that was done, but that was probably done through events.
Understood, they're just personal preference, like the High Valyrian culture change. I made a quickdiff of my blood inheritance changes compared to the mod, nothing concrete as I'm still experimenting as I play. What I'd like to do tho personally is add more cases like slightly diluted and mostly diluted always gives the child half blood trait, etc. quickdiff.net/?unique_id=EC616587-4AF2-E9F7-B824-E7BF4F95D19EThere is one thing I was unsure of, does valyrian_blood_events.txt take precedence over valyrian_blood_maintenance_events.txt or vice versa cause they are very similar? I went ahead and tried to make the same changes to both. |
|
|
|
Post by Azrael on Apr 11, 2020 0:45:54 GMT
That's cool if you want to make personal changes to fit what you want for gameplay. That's what submods are for. I don't know if I'll incorporate those changes into the submod, but I am open to suggestions, for this submod or any others. While I probably won't incorporate what you mentioned in the first part of your post, I did want feedback on the blood inheritance chance, so thank you. I never got any so I didn't change it, but after playing a couple games myself when I last played AGOT, I was thinking of reducing the chances and also writing the code to be more robust than it is right now. That change I probably will do at some point. I don't know when though; when I come back to AGOT and/or when I have the time to do so probably.
The part about giving traits straight to characters with unknown parents was for special cases like Jon Snow, who has his real parents hidden and for Aurane Waters, who is originally High Valyrian himself, but doesn't have both parents listed. I did this because the startup event that gives the traits is dependent on characters' parents and not themselves. I think there was some code in there for generated characters, like when you hire a soldier or a character gets created by an event, etc. which I did add a chance for them to have some sort of blood trait. That could be how you got a random Northman with full blood, if he/she doesn't have parents. I'll take a look and see if any of those should be lowered.
For the last part, I think the marriage AI is hard-coded for the most part. I don't think there's a way to mod how attractive traits are in terms of marriage for the AI. The AI generally does marriages based on how much prestige, alliances, etc. they would get. The workaround would probably have to be done through events. I know the main AGOT mod has it where Valyrian and characters with silver hair generally marry those of the same. I haven't looked at how that was done, but that was probably done through events.
Understood, they're just personal preference, like the High Valyrian culture change. I made a quickdiff of my blood inheritance changes compared to the mod, nothing concrete as I'm still experimenting as I play. What I'd like to do tho personally is add more cases like slightly diluted and mostly diluted always gives the child half blood trait, etc. quickdiff.net/?unique_id=EC616587-4AF2-E9F7-B824-E7BF4F95D19EThere is one thing I was unsure of, does valyrian_blood_events.txt take precedence over valyrian_blood_maintenance_events.txt or vice versa cause they are very similar? I went ahead and tried to make the same changes to both. I probably won't make it so slightly diluted and mostly diluted will always give half blood, but the chance will be greater for that to happen than the other possibilities. The differences between the two files are when the events fire and who they are targeting. The first event in valyrian_blood_events.txt is a startup event and only is fired at the beginning of the game using the on_startup on_action. The second event is for newborn characters, so that fires on_birth. The maintenance events are yearly_pulse events to make sure characters get a blood trait just in case who didn't receive the has_valyrian_blood flag, for newly created characters (like those randomly spawned sometimes when court numbers are low or when they just are generated in general), and for characters who don't have any characters listed at all for some reason. |
|
|
|
Post by 4eyedcuckoobird on Apr 11, 2020 5:07:53 GMT
Understood, they're just personal preference, like the High Valyrian culture change. I made a quickdiff of my blood inheritance changes compared to the mod, nothing concrete as I'm still experimenting as I play. What I'd like to do tho personally is add more cases like slightly diluted and mostly diluted always gives the child half blood trait, etc. quickdiff.net/?unique_id=EC616587-4AF2-E9F7-B824-E7BF4F95D19EThere is one thing I was unsure of, does valyrian_blood_events.txt take precedence over valyrian_blood_maintenance_events.txt or vice versa cause they are very similar? I went ahead and tried to make the same changes to both. I probably won't make it so slightly diluted and mostly diluted will always give half blood, but the chance will be greater for that to happen than the other possibilities. The differences between the two files are when the events fire and who they are targeting. The first event in valyrian_blood_events.txt is a startup event and only is fired at the beginning of the game using the on_startup on_action. The second event is for newborn characters, so that fires on_birth. The maintenance events are yearly_pulse events to make sure characters get a blood trait just in case who didn't receive the has_valyrian_blood flag, for newly created characters (like those randomly spawned sometimes when court numbers are low or when they just are generated in general), and for characters who don't have any characters listed at all for some reason. OK that would be alright too. I like the values I've tweaked it to now. Thanks again for the mod! |
|
|
|
Post by alvis14 on Apr 12, 2020 13:50:16 GMT
Noob question : Compatches replace the Valyrian Blood mod ?
|
|
|
|
Post by Azrael on Apr 12, 2020 23:53:34 GMT
Noob question : Compatches replace the Valyrian Blood mod ? For compatches you'll need the mods they're made for and the compatch. |
|
|
|
Post by jonothor on Apr 13, 2020 1:32:35 GMT
Hey Azrael, are you planning on making this compatible with the new version of More Bloodlines?
|
|
|
|
Post by Azrael on Apr 15, 2020 23:01:59 GMT
Hey Azrael, are you planning on making this compatible with the new version of More Bloodlines? Eventually, yes; don't have the time to do so at the moment though. If someone wants to make an unofficial compatch and post it in this thread until then, that's cool. |
|
|
|
Post by Azrael on May 4, 2020 1:22:14 GMT
I updated the submod (both for 2.0 and 2.1) with more robust trait inheritance chances. I also made a few more changes in dragon_decisions.txt and dragon_events.txt (commenting out things like high_valyrian_dynasty_trigger, silver_hair_ethnicity_trigger, etc.) to make the blood traits much more important to have for those actions.
The compatibility patches for More Bloodlines have not been updated yet.
|
|
|
|
Post by Azrael on May 4, 2020 2:57:06 GMT
Compatches for More Bloodlines have been updated. Please remember to use the appropriate compatches for the appropriate versions of the dependent submods.
|
|
|
|
Post by Azrael on May 9, 2020 14:42:25 GMT
Submod updated with a quickfix. I missed some things I needed to comment out in the tame a dragon objective; should be save-game compatible.
|
|
