|
|
Post by henriqueabreu on Oct 23, 2018 22:37:53 GMT
I Knew about the 1.7 dueling bug.I am using 1.7.1 and when this dueling bug began to happen,I disabled your mod and the duels were fine.I would hate to play without your mod, it is too good,but in later patches could you see if there is something wrong?I don't really know how to work with mods
|
|
|
|
Post by LancelotLoire on Oct 24, 2018 1:07:48 GMT
Well like I said am not planning anything ck2 related until after holy fury comes out. I think we're getting closer to that happening so the wait isnt gonna be around much longer.
|
|
|
|
Post by aracil on Oct 26, 2018 17:38:20 GMT
Man you guys did a hell of a job converting my swords to artifacts; much better than I can do with my limited skills. I'm Daniel, btw.  |
|
|
|
Post by LancelotLoire on Oct 26, 2018 21:36:18 GMT
Ah hey Daniel!  |
|
|
|
Post by kappa on Dec 25, 2018 15:20:15 GMT
Hey I don't know if you're back or not yet but if you are it would be cool to see you implement a mendelian model like this mod steamcommunity.com/sharedfiles/filedetails/?id=1518305370 ,it does a better job of distributing multi tiered traits so that you arent punished for having higher tiers because of lower inheritance chance. Very interesting model, would definitely take a little work to get it set up with your traits but honestly not that long. I fiddled around with it for a few hours and it's quite easily modular. |
|
|
|
Post by LancelotLoire on Dec 26, 2018 2:59:59 GMT
My god... that must person must have way too much time on his hands lol. I'll take a look at it later (About to play some God of War), but this does sound pretty neat. I'll have to do some tests and see if I should ask to borrow it.
|
|
Nervosi
Member
This community and it's modders have brought me so much Joy, thank you sincerely ^_^
Posts: 368
|
Post by Nervosi on Dec 26, 2018 7:36:36 GMT
Oh yes! i'd absolutely adore Improved Genetics in Congen Overhaul,it'd be awesome if you could pull that off for the new Holy Fury update whenever that'll be Lancelot,nonetheless,love your work!
|
|
|
|
Post by LancelotLoire on Dec 26, 2018 9:57:41 GMT
Section of his code...
if = {
limit = {
father = {
NOT = {
OR = {
has_character_flag = attr_AA
has_character_flag = attr_Aa
has_character_flag = attr_aa
has_character_flag = attr_BB
has_character_flag = attr_Bb
has_character_flag = attr_bb
has_character_flag = attr_CC
has_character_flag = attr_Cc
has_character_flag = attr_cc
}
}
}
}
father = {
if = {
limit = {
trait = fair
}
random_list = {
2 = {
set_character_flag = attr_AA
}
2 = {
set_character_flag = attr_Aa
}
}
random_list = {
2 = {
set_character_flag = attr_BB
}
2 = {
set_character_flag = attr_Bb
}
}
random_list = {
2 = {
set_character_flag = attr_CC
}
2 = {
set_character_flag = attr_Cc
}
}
}
Section of my code.. immediate = {
if = {
limit = {
AND = {
true_father_even_if_dead = { trait = agile_2 }
mother_even_if_dead = { trait = agile_2 }
}
}
random_list = {
50 = { add_trait = agile_2 }
75 = { add_trait = agile_1 }
100 = { add_trait = agile }
9800 = { }
35 = { add_trait = lazy }
25 = { add_trait = lazy_1 }
20 = { add_trait = lazy_2 }
}
}
if = {
limit = {
AND = {
true_father_even_if_dead = { trait = agile_2 }
mother_even_if_dead = { trait = agile_1 }
}
}
random_list = {
45 = { add_trait = agile_2 }
65 = { add_trait = agile_1 }
90 = { add_trait = agile }
9800 = { }
40 = { add_trait = lazy }
25 = { add_trait = lazy_1 }
25 = { add_trait = lazy_2 }
}
}
Looks like he's using a method of character flags AA/Aa/aa, BB/Bb/bb, CC/Cc/cc for each trait, then assigning a point value so if you reach a certain threshold it causes a chance for certain traits to pop up. I see about 5 trait level possibilities for the biggest (equivalent would be fair_1, fair, nothing, ugly, ugly_1). It's nicely made. |
|
|
|
Post by kappa on Dec 26, 2018 15:25:53 GMT
I will admit there is two things Im a little concerned about with trying to implement that mod, one is how i would interact with the already pre existing vanilla congenital events (so for example if a High Valyrian gets given "fair" from a birth event but "ugly" from the DNA which would get priority) my second concern is that it really doesnt account for ethnicity at all, I think both for simplicities sake and the sake of not getting into race politics (which I'm in agreement with) however certain ethnicities in ASOIAF are subjectively more attractive on average and some like the Ibbenese aren't even neccessarily homo sapiens (more like Neanderthals?). I was trying to come up with a theoretical way to account for that elegantly but I'm too stupid for that stuff and gave up after a couple hours. But yea, it wouldn't work if it'd have to give up having the Mantaryans be more deformed for example or the Lysene be more attractive etc.
I thought I'd link it anyway but the more I thought about it the more concerns I had, if the script could be adapted somehow it'd be an even more elegant way of showing those cultural traits though theoretically.
|
|
joca
Member
Posts: 29 
|
Post by joca on Dec 26, 2018 15:31:20 GMT
Hey! (Long time lurker and with a Degree in Biology here) Crimson9's mod information explains it pretty well but if you have any doubts/questions about said character flags I'm happy to help explain it to you if you have no clue what's going on about Recessive/Dominant traits or Incomplete Dominance vs Co-Dominance (especially interesting in Tyrion, who has the genius trait+dwarf trait) Anything to get this mod updated since I, for the life of me, can't seem to play CK2 AGOT for long without it xD |
|
|
|
Post by kappa on Dec 26, 2018 15:44:28 GMT
I understand crimon9's mod pretty well myself but as I said above I can't think of an obvious solution to "biased" genetics. In that certain cultures should be leaning towards certain types of traits. If you know of an elegant solution to that I think it could be adapted very well.
|
|
|
|
Post by LancelotLoire on Dec 26, 2018 22:36:26 GMT
Well as far as I take it the dominant/recessive stuff AA/Aa/aa BB/Bb/bb CC/Cc/cc already takes care of that itself forcing certain dna groupings to lead towards certain congenital traits. Thus making the the High Valyrian pretty event a bit obsolete... Of course the big kicker would be for brand new characters (newly employed) in which case we'd want to modify something so that their flags are more oriented towards the FAIR trait and the like. Other then making a change so that new characters lean heavy I don't know if any other changes need to take place. That'll cause a better leaning towards realism and allow for an influx of the more positive "genes" to come back into the game. Of Course we can do some tweaking outside of the main inheritance method for certain cultures. For instance if AA/BB/CC has a 75% chance of giving the trait FAIR and Aa/Bb/Cc has a 5% chance of having FAIR. If a character is High Valyrian and they are Aa/Bb/Cc they can have a 25% chance to get FAIR added through a separate event (The High Valyrian event) OR their flags can be straight up changed through event to "fix" them more towards their AGOT norms. The 1st option I find more elegant but it also could vanish pretty quickly. The 2nd option is far more intrusive and actually repairs things to keep them in check. joca: We need a new version of AGOT first before anything can happen |
|
|
|
Post by kappa on Dec 27, 2018 4:32:34 GMT
Well what it does is at the beginning of the game it kicks off dna strands for all characters randomly, however if they already have a genetic trait (so with your mod this would be like fair, fair_1, fair_2 etc) it would pre dispose them to a certain grouping. However some of the targaryens (many in fact) do not start with any of the fair traits (although arguably more should based on the lore of the "High Valyrian looks" being so attractive), and of course a few generations of marriage can absolutely ruin their DNA. That's why there'd need to be certain alterations for certain cultures to self correct to some degree. The majority of cultures could be neutral but the following would need some level of self correction.
Valyrians and Lysene would trend towards AA/BB/CC attractiveness (or just have a script to over write with the fair/fair_1/fair_2 traits if that's easier), Mantaryans would trend towards aa/bb/cc for stuff like clubfooted/hunchback etc (or application script again), Ibbenese towards ugly, Leng/Tall Men towards tall there's some others too Im forgetting.
The point is though that without self correction in my tests even a perfect set (so let's say AA/BB/CC in attractiveness) will eventually average out over a number of generations, that's why the self correcting needs to be there to ensure that you dont suddenly have a Targaryen house full of ugly children.
|
|
|
|
Post by ahutch12 on Jan 12, 2019 17:44:45 GMT
when will this be updated to the newest version
|
|
|
|
Post by crayon on Jan 13, 2019 2:05:35 GMT
Congenital Overhaul is easily my favorite sub-mod for AGOT CK2, so thank you for all of the hard work on this mod and on keeping it updated! I'm looking forward to it being ready for 1.8.
With that said, I'm curious if it would be possible to make a version of the mod that only includes the adjusted and new genetic traits, sans any of the changes to portraits and so on? That would be wonderful for compatibility with some of the other mods out there. I like the new and rebalanced mods from the overhaul far too much to play without it, but it would be nice to be able to experiment with other portrait sub-mods while retaining the better traits.
|
|
